search

waterthetrees / wtt_db

waterthetrees.com local dev database
Creative Commons Zero v1.0 Universal
0 stars 0 forks source link

Change id to id_name in sources/crosswalk, Change ref to id_reference… #50

Closed zoobot closed 1 year ago

zoobot commented 1 year ago

…, drop id_city_name

zoobot commented 1 year ago

The new source route is ready to go, requires all these PRs to go in at once. Thanks for looking. You can run server tests with npm test -- sources.test.js Front end snapshot tests with npm test

https://github.com/waterthetrees/wtt_db/pull/50

https://github.com/waterthetrees/wtt_front/pull/401

https://github.com/waterthetrees/wtt_server/pull/126

zoobot commented 1 year ago

I don't have much context, but I left some comments. Overall looks good to me, but the changes look a bit risky right before the demo this wed. Are you looking to merge in this weekend?

We can leave it out until after the demo. I don't know that they will care too much about this since they likely have one data source and it sounds like its not on a public url.

zoobot commented 1 year ago

This is ready to go. Thanks for reviewing!!