waterthetrees / wtt_front

Water the Trees React frontend
https://waterthetrees.com
Creative Commons Zero v1.0 Universal
9 stars 24 forks source link

Deal with vacant/possible tree/bad naming location site ids #237

Open zoobot opened 2 years ago

zoobot commented 2 years ago

Deal with vacant/possible tree/bad common name location site ids

In cases where common, scientific are malformed or missing or vacant site, how do we update the id? Should we just delete old version and create new tree?

zoobot commented 2 years ago

Option 1

  1. Allow the id to be updated so it retains the history. a. update treedata, treehistory, users, treelikes, treeadoptions tables b. email city on edit c. Assume city does not update their download file
    1. Compare coordinates/planted dates and only show more recent one

Option 2

  1. Allow multiples per coordinates a. copy history from old id but leave previous record intact b. check for most recent planted date per lng/lat b. email city data file of all monthly edits or combo of edits and their current data in their data format

Option 3

  1. Redo the ids entirely without common and scientific a. Use only lng/lat/sourceId or even just a lng/lat geohash b. Deal with collisions by adding to tree count.
fwextensions commented 2 years ago

As of #238, users will be able to remove trees but not re-add them in the same spot., until this gets resolved.

zoobot commented 2 years ago

Option 3 is out, way too many collisions

  1. Redo the ids entirely without common and scientific a. Use only lng/lat/sourceId or even just a lng/lat geohash b. Deal with collisions by adding to tree count.
zoobot commented 2 years ago

Try option 4

  1. Redo ids entirely without common and scientific- try without the geohash, try without the sourceid+geohash
zoobot commented 2 years ago

Option 4 is a no go, too many collisions.