Closed GoogleCodeExporter closed 9 years ago
Original comment by kjellan...@google.com
on 30 Aug 2013 at 7:51
I411 is a format with 1/4 width and full height chrominance subsampling.
Its the only format with 1/4 width - most are 1/2 width.
The issue is likely in the unittest not the code itself.
This being SSSE3 failing, the first thing I would try is disabling SSSE3
export LIBYUV_DISABLE_SSSE3=1
and then run the test. If it fails in C as well, the issue is more likely in
the test itself.
Original comment by fbarch...@google.com
on 12 Sep 2013 at 1:24
Right, if I set LIBYUV_DISABLE_SSSE3=1 the test passes without errors. Does
that help you to fix this?
Original comment by kjellan...@google.com
on 17 Sep 2013 at 9:56
Yes that does help. That tells me its an SSSE3 overread.
Either the calling code did it on purpose, since its an optimization.
Or the low level did it, most likely by accident. But SIMD can only read as
little as 4 bytes (movd), so it may be for technical reasons.
Really I should repro the issue, but first step is failing:
d:\src\libyuv\trunk>ninja -C out\Debug
ninja: Entering directory `out\Debug'
[80/150] CXX obj\source\libyuv.row_win.obj
FAILED: ninja -t msvc -o obj\source\libyuv.row_win.obj -e environment.x86 --
"C:\Program Files (x86)\Microsoft Visual Studio 11.0\VC
\bin\cl.exe" /nologo /showIncludes /FC @obj\source\libyuv.row_win.obj.rsp /c
..\..\source\row_win.cc /Foobj\source\libyuv.row_win.ob
j /Fdobj\libyuv.pdb
d:\src\libyuv\trunk\source\row_win.cc(5114) : error C2400: inline assembler
syntax error in 'opcode'; found 'SHL'
d:\src\libyuv\trunk\source\row_win.cc(5118) : error C2400: inline assembler
syntax error in 'opcode'; found 'EQ'
d:\src\libyuv\trunk\source\row_win.cc(5123) : error C2400: inline assembler
syntax error in 'opcode'; found 'SHR'
d:\src\libyuv\trunk\source\row_win.cc(5125) : error C2400: inline assembler
syntax error in 'opcode'; found 'SHL'
d:\src\libyuv\trunk\source\row_win.cc(5144) : error C2400: inline assembler
syntax error in 'opcode'; found 'EQ'
d:\src\libyuv\trunk\source\row_win.cc(5145) : error C2412: 'convertloop' :
case-insensitive label redefined
d:\src\libyuv\trunk\source\row_win.cc(5147) : error C2400: inline assembler
syntax error in 'opcode'; found 'SHR'
d:\src\libyuv\trunk\source\row_win.cc(5162) : error C2400: inline assembler
syntax error in 'opcode'; found 'SHL'
d:\src\libyuv\trunk\source\row_win.cc(5163) : error C2400: inline assembler
syntax error in 'opcode'; found 'EQ'
d:\src\libyuv\trunk\source\row_win.cc(5165) : error C2400: inline assembler
syntax error in 'opcode'; found 'SHR'
[80/150] CXX obj\testing\gtest\src\gtest.gtest.obj
ninja: build stopped: subcommand failed.
Original comment by fbarch...@google.com
on 17 Sep 2013 at 5:55
Some documentation
http://www.chromium.org/developers/how-tos/using-drmemory
Original comment by fbarch...@google.com
on 17 Sep 2013 at 7:36
r798 should pass all drmemory tests.
2 tests disabled and need further investigation: I411ToARGB and Sobel
Original comment by fbarch...@google.com
on 24 Sep 2013 at 7:56
r799 fixes I411ToARGB.
r800 fixes Sobel.
All errors resolved.
Performance is a little slow on large scale factors.
Warnings on memory allocations.
Original comment by fbarch...@google.com
on 24 Sep 2013 at 11:20
Yes, sobel is fixed and we've rolled libyuv to r874 for webrtc.
Original comment by fbarch...@google.com
on 26 Nov 2013 at 11:01
Original issue reported on code.google.com by
kjellan...@google.com
on 30 Aug 2013 at 7:48