Add a flag for setting the timeout

wathiede / surfer

Surfer is a simple program to scrape the status page of the Motorola/ARRIS SB6121 or SB6183 cable modem. It exports metrics in a format compatible with http://prometheus.io/

Apache License 2.0

7 stars 3 forks source link

Add a flag for setting the timeout #3

Closed wrong-kendall closed 7 years ago

wrong-kendall commented 7 years ago

I want the ability to specify a timeout for retrieving cable modem stats instead of the default 1s. I'm not sure why my cablem modem takes 10-30s to return a status page but until I figure that out, this lets me monitor the other stats I care abote.

wathiede commented 7 years ago

I am utterly shocked that my arbitrarily chosen timeout wasn't sufficient. Ironically I was remembering @wac- complain about overly long timeouts for RPC deadlines when I chose 1s over 30s.

wac- commented 7 years ago

A status page capable of, at most, 0.04 qps? That would be unthinkable...