search

wathiede / surfer

Surfer is a simple program to scrape the status page of the Motorola/ARRIS SB6121 or SB6183 cable modem. It exports metrics in a format compatible with http://prometheus.io/
Apache License 2.0
7 stars 3 forks source link

Add support for self signed certificates #8

Closed wrong-kendall closed 3 years ago

wrong-kendall commented 3 years ago

Modify the Modem interface to accept an http.Client. Initialize the basic http.Client with an http.Transport that allows disabling TLS cert checks. The motivation for this is that the SB8200 on Wave uses a self signed cert.

wrong-kendall commented 3 years ago

@wathiede How do you feel about this style of change? Basically, are you okay with unifying every modem's http client and passing it in? If you're okay with this I'll continue down this path. Otherwise, let me know what you'd prefer.

wrong-kendall commented 3 years ago

Talked offline with wathiede and he was okay with the approach for now (though some unification could definitely be used so that all Modems don't have to implement get(). Marking this ready for review for now