search

watilde / a-letter-for-you

:love_letter: Send a short encrypted message by GitHub ID
https://www.npmjs.com/package/a-letter-for-you
MIT License
0 stars 0 forks source link

only ssh-rsa format supported #1

Open bdmorin opened 9 years ago

bdmorin commented 9 years ago 
-> % a-letter-for-you -u strozykowski -m "ur a punk" -o ben.txt

/Users/bdmorin/.nvm/v0.10.36/lib/node_modules/a-letter-for-you/node_modules/ursa/lib/ursa.js:238
        throw new TypeError('Only "ssh-rsa" format supported');
              ^
TypeError: Only "ssh-rsa" format supported
    at Object.openSshPublicKey (/Users/bdmorin/.nvm/v0.10.36/lib/node_modules/a-letter-for-you/node_modules/ursa/lib/ursa.js:238:15)
    at encryptString (/Users/bdmorin/.nvm/v0.10.36/lib/node_modules/a-letter-for-you/a-letter-for-you.js:39:18)
    at /Users/bdmorin/.nvm/v0.10.36/lib/node_modules/a-letter-for-you/a-letter-for-you.js:35:3
    at IncomingMessage.<anonymous> (/Users/bdmorin/.nvm/v0.10.36/lib/node_modules/a-letter-for-you/a-letter-for-you.js:73:7)
    at IncomingMessage.emit (events.js:117:20)
    at _stream_readable.js:944:16
    at process._tickCallback (node.js:442:13)

This was due to my recipient had a ssh-dss key uploaded. After picking on him, he changed it and everything was fine. If I knew node better I'd add a check for compatible key, since I don't, I'm simply reporting it as an issue.

Very cool idea.

watilde commented 9 years ago

Oh thanks for reporting a error! I'm sorry for that current code actually supported only "ssh-rsa" format. So, I'll try to fix sometimes and just put a patch_welcome tag to here.