search

watilde / beeplay

Write a song in JavaScript
http://watilde.github.io/beeplay
MIT License
1.04k stars 54 forks source link

Fixes sounds isn't played #2

Closed kubosho closed 10 years ago

kubosho commented 10 years ago

Fixes sounds isn't played, throw error "Uncaught TypeError: undefined is not a function" in beeplay.js:71.

watilde commented 10 years ago

@kubosho Thanks for your PR! LGTM :smiley_cat: Could you please write description in English and tell me more information how to reproduce the error please...?

kubosho commented 10 years ago

OS: Mac OS X 10.9.2

Not working browser list:

How to reproduce:

  1. Click the play button in demo site, sounds isn't played.
  2. Open browser developer tools, show error "Uncaught TypeError: undefined is not a function beeplay.js:71" in console.
  3. Set a breakpoint in beeplay.js:71
  4. Execute code src.noteOn(that.time) in console.
  5. Throw error "TypeError: undefined is not a function".
watilde commented 10 years ago

Looks perfect now! Thanks for following up hard <3.