Verify if callback 'done' is defined, always print stdout

watilde / tvm

TypeScript Version Manager

http://watilde.github.io/tvm

32 stars 5 forks source link

Closed dms1lva closed 6 years ago

dms1lva commented 6 years ago

Two fixes

In install and install_latest, if the specified version already existed, it would call the callback without verifying if it was passed.
When launching tsc to compile the file, it would only print out the error object if it existed. Issue with this is we don't see compiler errors. Fix this by always printing stdout. Also, use console.log instead of util.print.

watilde commented 6 years ago

LGTM. Thanks! I will ship this.

watilde commented 6 years ago

This patch was released as v0.8.13. Thank you :3