search

watir / tap_watir

Watir for Mobile Devices (currently pre-beta status but in active development)
MIT License
17 stars 5 forks source link

use appium core 2.x and remove self #16

Open KazuCocoa opened 6 years ago

KazuCocoa commented 6 years ago

In https://github.com/appium/ruby_lib_core/pull/136 , I've got rid of self from initialisation of appium core. A user who only uses the core library, we no longer set self as the argument.

titusfortner commented 6 years ago

Excellent! I was meaning to ask why that was necessary. Thanks.

On Mon, Aug 27, 2018, 6:23 AM Kazuaki Matsuo notifications@github.com wrote:

In appium/ruby_lib_core#136 https://github.com/appium/ruby_lib_core/pull/136 , I've got rid of self from initialisation of appium core. A user who only uses the core library, we no longer set self as the argument.

You can view, comment on, or merge this pull request online at:

https://github.com/watir/tap_watir/pull/16 Commit Summary

  • use appium core 2.x and remove self

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/watir/tap_watir/pull/16, or mute the thread https://github.com/notifications/unsubscribe-auth/AAvb4f11Tb59dcBwMbt_ifwa4XYszDLtks5uU_LvgaJpZM4WNx8o .

KazuCocoa commented 6 years ago

yeah, that was a historical reason... Feel free to merge this 👍