watir / watir_meta

Former watir.gem that referenced both watir-webdriver and watir-classic
http://watir.com
Other
407 stars 45 forks source link

Requiring 'watir-webdriver' can lead to infinite loops. #11

Open mhodgson opened 11 years ago

mhodgson commented 11 years ago

If you require 'watir-webdriver' explicitly in you tests, it may cause Watir::Browser.new to lead to an infinite loop. I suggest two things:

  1. Update the README to make this clear.
  2. Eventually refactor the code to not redefine the initialize method based on what value has been set for the driver. A fairly simple inheritance structure should help here.
jarmo commented 11 years ago

Additional conversation about this topic at https://github.com/watir/watir/commit/4e2fa0a279d09b3ebc2b22b23302d1be8aa8add3

I'm against updating README, because this still seems more like a bug to me than a feature which should be documented.

Watir should detect if loading has been already done and skip that phase if needed.