watkin36 / codelab-css-transitions-animations-transforms

https://github.com
0 stars 0 forks source link

Code Lab Feedback #1

Open watkin36 opened 8 years ago

watkin36 commented 8 years ago

Hey @stuartpearman, can you take a look at this? It's hosted here and meets the following project criteria:

stuartpearman commented 8 years ago

Hey @watkin36, sorry for such a delay! It's looking good but there's a few things missing before it's up to ship-it squirrel standards.

You have a transition added to your td element:

td {transition: all 2s;}

To get a nice smooth transition for your other table effects, add a transition to your table and tr elements as well.

Also, have the zombie animation activate on hover instead. To do this, just add the pseudo class :hover to your img selector:

img:hover { ... }
watkin36 commented 8 years ago

Thanks! I think I have it all addressed in the recently uploaded files. The new url is www.unwieldy-plate.surge.sh

stuartpearman commented 8 years ago

Looks great Scott! It's also good to know that MSU has the lowest zombie population :mask: :shipit: