watson-developer-cloud / assistant-with-discovery

DEPRECATED: this application is deprecated and thus will not receive fixes or security updates. It is archived for educational purposes, but may not function.
Apache License 2.0
145 stars 340 forks source link

Fixed the markdown, made custom config optional, took out bluemix deploy #87

Closed ghost closed 7 years ago

germanattanasio commented 7 years ago

@jscherping you need to sync your PR because it has conflicts

germanattanasio commented 7 years ago

You also need to add your IBM email to your github profile

codecov-io commented 7 years ago

Codecov Report

Merging #87 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #87   +/-   ##
=========================================
  Coverage     13.15%   13.15%           
  Complexity       12       12           
=========================================
  Files            10       10           
  Lines           266      266           
  Branches         29       29           
=========================================
  Hits             35       35           
  Misses          224      224           
  Partials          7        7

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fe49f01...9ae13fa. Read the comment docs.

ghost commented 7 years ago

@germanattanasio I added my IBM email and fixed the conflict. Is there anything else I should do for this?