watson-developer-cloud / botkit-middleware

A middleware to connect Watson Conversation Service to different chat channels using Botkit
https://www.npmjs.com/package/botkit-middleware-watson
Apache License 2.0
207 stars 255 forks source link

Fix issue #125 #127

Closed jganseman closed 6 years ago

jganseman commented 6 years ago

I think this should fix issue #125 : adding extra checks in the examples, that implement more graceful error handling, for future users to base their code on. (Not sure if there is a JSON Schema of the Watson Conversation message format somewhere that would allow for more finegrained compliance checking?)

germanattanasio commented 6 years ago

@Naktibalda What do you think about this? I still feel that returning a custom English message like "I'm sorry, but for technical reasons I can't respond to your message" is not the right solution. I would prefer to return an empty message

Naktibalda commented 6 years ago

I actually use this message in my project and I updated simple-bot example a while ago, but left multi-bot unchanged.

watson-github-bot commented 6 years ago

:tada: This PR is included in version 1.8.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: