watson-developer-cloud / botkit-middleware

A middleware to connect Watson Conversation Service to different chat channels using Botkit

https://www.npmjs.com/package/botkit-middleware-watson

Apache License 2.0

207 stars 255 forks source link

feat: Update README, tests, dependencies #179

Closed germanattanasio closed 5 years ago

germanattanasio commented 5 years ago

@Naktibalda I did some updates to your code to update the tests to use typescript and cleanup extra code that we had for when we were using plain javascript.

The code is now in src and lib is ignore from the repository.
The npm package will have lib with the types and javascript but not src with the typescript.
simple-bot was updated
multi-bot was not updated as I ran out of time 😞
switched to jest and added codecov for code coverage
Removed dependencies that were not needed.

What I need.

Can you please test that it works as expected for you?
I tried updating the README but I would like your 👀 there too.

---- for semantic versioning ---

BREAKING CHANGE:

Botkit updated to 4.0.0 which means there are a lot of changes to use your bot with botkit now.
Only simple bot example was updated.

Naktibalda commented 5 years ago

Is ignoring compiled files a standard practice in node-sdk? It makes it impossible to install this library from branch because I get no src/ and no lib/.

How am I supposed to test my changes now? I would rather remove package-lock.json from git, because this is a library, so lock file doesn't matter.

germanattanasio commented 5 years ago

@Naktibalda I added back the lib files so that you can test this from github.

codecov-io commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (botkit-next@9ac00a3). Click here to learn what that means. The diff coverage is 78.57%.

@@              Coverage Diff              @@
##             botkit-next    #179   +/-   ##
=============================================
  Coverage               ?   78.5%           
=============================================
  Files                  ?       2           
  Lines                  ?     107           
  Branches               ?      22           
=============================================
  Hits                   ?      84           
  Misses                 ?      19           
  Partials               ?       4

Impacted Files	Coverage Δ
lib/utils.js	`100% <ø> (ø)`
lib/index.js	`65.15% <78.57%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9ac00a3...47c18b5. Read the comment docs.

watson-github-bot commented 5 years ago

:tada: This PR is included in version 2.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: