search

watson-developer-cloud / botkit-middleware

A middleware to connect Watson Conversation Service to different chat channels using Botkit
https://www.npmjs.com/package/botkit-middleware-watson
Apache License 2.0
206 stars 255 forks source link

fix: UpdateContext documentation #182

Closed Naktibalda closed 5 years ago

Naktibalda commented 5 years ago

I used updateContext yesterday and I discovered 2 things:

  1. updateContext requires a full context object, so the signature was incorrect.
  2. It isn't documented in README anymore.

I fixed both issues in this pull request.

Unrelated question: Are source maps really necessary? They guarantee merge conflicts when there is more than 1 outstanding pull request. Options: a) disable source maps in tsconfig, b) .gitignore them.

codecov-io commented 5 years ago

Codecov Report

Merging #182 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #182   +/-   ##
======================================
  Coverage    78.5%   78.5%           
======================================
  Files           2       2           
  Lines         107     107           
  Branches       22      22           
======================================
  Hits           84      84           
  Misses         19      19           
  Partials        4       4
Impacted Files Coverage Δ
lib/index.js 65.15% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 62947d9...508b040. Read the comment docs.

watson-github-bot commented 5 years ago

:tada: This PR is included in version 2.1.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: