watson-developer-cloud / discovery-components

IBM Watson Discovery components
https://watson-developer-cloud.github.io/discovery-components/storybook
Apache License 2.0
20 stars 38 forks source link

fix: callback pdf render error #467

Closed dorianmiller closed 1 year ago

dorianmiller commented 1 year ago

What do these changes do/fix?

Problem when a PDF fails to render, the document view is blank. The fix defaults to display the text version.

How do you test/verify these changes?

Will add a unit test to load an invalid pdf file.

Have you documented your changes (if necessary)?

Are there any breaking changes included in this pull request?

No

CLAassistant commented 1 year ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.