search

watson-developer-cloud / discovery-components

IBM Watson Discovery components
https://watson-developer-cloud.github.io/discovery-components/storybook
Apache License 2.0
22 stars 38 forks source link

Update peer dependency for @ibm-watson/discovery-styles #491

Closed spark-ming closed 1 year ago

spark-ming commented 1 year ago

Currently, the peer dependency for the @ibm-watson/discovery-styles is set to 1.x.x which is the old and outdated package. This causes issues with building due to the way it references the styles (starts with ~).

Right now, we are having to work around with npm i --force

https://github.com/watson-developer-cloud/discovery-components/blob/47bae3c7bb5b3160630ef969e220525c58393d9c/packages/discovery-react-components/package.json#L84

spark-ming commented 1 year ago

@jhpedemonte we are happy to open a PR for this to fix this (bounded versions) if you think this is the fastest way to resolve this. Thanks.

spark-ming commented 1 year ago

Thanks so much @jhpedemonte! Looking forward to removing the npm ci --force from our docs and build pipeline 🎉