watson-developer-cloud / discovery-components

IBM Watson Discovery components
https://watson-developer-cloud.github.io/discovery-components/storybook
Apache License 2.0
22 stars 38 forks source link

feat: Text view, tooltip for enrichments #530

Closed dorianmiller closed 11 months ago

dorianmiller commented 11 months ago

What do these changes do/fix?

Run the discovery-components from within the Discovery Tooling:

How do you test/verify these changes?

Run the discovery-components from within the Discovery Tooling.

Have you documented your changes (if necessary)?

None

Are there any breaking changes included in this pull request?

No

CLAassistant commented 11 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

dorianmiller commented 11 months ago

Test tooltip with multiple entries: Uncomment these lines

image
// tableContent.push({
  //   enrichColor: 'red',
  //   enrichFacetDisplayname: 'short',
  //   enrichValue: ellipsisMiddle('extra super duper long long 44 characters')
  // });
  // tableContent.push({
  //   enrichColor: 'green',
  //   enrichFacetDisplayname: ellipsisMiddle('extra super duper long long 44 characters'),
  //   enrichValue: 'short'
  // });
dorianmiller commented 11 months ago

Thanks for empty tooltip test case. I fixed it.