Closed dorianmiller closed 11 months ago
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
Test tooltip with multiple entries: Uncomment these lines
// tableContent.push({
// enrichColor: 'red',
// enrichFacetDisplayname: 'short',
// enrichValue: ellipsisMiddle('extra super duper long long 44 characters')
// });
// tableContent.push({
// enrichColor: 'green',
// enrichFacetDisplayname: ellipsisMiddle('extra super duper long long 44 characters'),
// enrichValue: 'short'
// });
Thanks for empty tooltip test case. I fixed it.
What do these changes do/fix?
Run the discovery-components from within the Discovery Tooling:
Tooltip in text view![image](https://github.com/watson-developer-cloud/discovery-components/assets/45341518/bbef5bcb-dd85-41cd-8c08-836e34dc8fa8)
Keyword as category in tooltip![image](https://github.com/watson-developer-cloud/discovery-components/assets/45341518/cb10247a-1bac-4ec3-ab57-b5241f846a0b)
Highlight is 20% opacity
improvements from pass issue: https://github.com/watson-developer-cloud/discovery-components/pull/529#discussion_r1304471348
How do you test/verify these changes?
Run the discovery-components from within the Discovery Tooling.
Have you documented your changes (if necessary)?
None
Are there any breaking changes included in this pull request?
No