fix: upgrade to pdfjs v4

watson-developer-cloud / discovery-components

IBM Watson Discovery components

https://watson-developer-cloud.github.io/discovery-components/storybook

Apache License 2.0

22 stars 38 forks source link

fix: upgrade to pdfjs v4 #577

Closed jhpedemonte closed 1 week ago

jhpedemonte commented 2 months ago

What do these changes do/fix?

Upgrade to latest PDF.js build.

Implements https://github.ibm.com/Watson-Discovery/disco-issue-tracker/issues/19108

How do you test/verify these changes?

Have you documented your changes (if necessary)?

Are there any breaking changes included in this pull request?

Check PDF views in Storybook
Check PDF view in example app. To see a PDF in example app, create a project and upload "Art Effects.pdf". In app, search for "art effects" and pick first result to see PDF view.

jhpedemonte commented 3 weeks ago

To do

[x] Fix tests
[x] Clean up packages/discovery-react-components/src/components/DocumentPreview/components/PdfViewer/typings.d.ts

noah-eigenfeld commented 2 weeks ago

Saw this on my own branch when I last tried to make updates, and I still see it now on yours: for some reason the height of the rendered textLayer is twice the required height of the PDF itself. Nothing breaks because of this (at least, I don't think it does), but the user can scroll really far down in the editor.

jhpedemonte commented 2 weeks ago

the height of the rendered textLayer is twice the required height of the PDF itself

You're still seeing this? I explicitly updated the CSS to fix this, so odd that it would still be around.