search

watson-developer-cloud / dotnet-standard-sdk

:new::new::new:.NET Standard library to access Watson Services.
https://www.nuget.org/profiles/ibm-watson
Apache License 2.0
147 stars 117 forks source link

[dotnet-standard-sdk] Inconsistency between Model namespaces #38

Closed mediumTaj closed 7 years ago

mediumTaj commented 7 years ago

There is an inconsistency between Model vs Models in the namespace of the DataModels.

IBM.WatsonDeveloperCloud.TextToSpeech.v1.Model

IBM.WatsonDeveloperCloud.SpeechToText.v1.Models

Which one should we stick with? Or should we have a separate namespace for Data Models? Should we keep Data Models in the version namespace for each service?

atilatosta commented 7 years ago

@mediumTaj In fact the Models is the namespace, the Model is the business class. Actually, when I built it, I realized it got a bit confusing. What do you think about this? How are you in the Java SDK?

mediumTaj commented 7 years ago

@atilatosta Looks like they use model.

https://github.com/watson-developer-cloud/java-sdk/blob/master/discovery/src/main/java/com/ibm/watson/developer_cloud/discovery/v1/Discovery.java

import com.ibm.watson.developer_cloud.discovery.v1.model.collection.CreateCollectionResponse;