watson-developer-cloud / dotnet-standard-sdk

:new::new::new:.NET Standard library to access Watson Services.
https://www.nuget.org/profiles/ibm-watson
Apache License 2.0
148 stars 117 forks source link

websockets #455

Closed kevinkowa closed 3 years ago

kevinkowa commented 3 years ago

PR for adding websockets to text-to-speech & speech-to-text

lgtm-com[bot] commented 3 years ago

This pull request introduces 2 alerts when merging 61737a885b6f12cc4ed75f627d5388f3e4f15c29 into 21d9b90bdc081b5659ce60f1b6bcd8c100d9e69f - view on LGTM.com

new alerts:

mediumTaj commented 3 years ago

We should create a websockets-rc branch so these are not released. We can do manual websockets-rc01, etc releases to nuget for stt and tts so customer can test

lgtm-com[bot] commented 3 years ago

This pull request introduces 4 alerts when merging 28cca02a4efb2d5c04d5b8711019861a30398c21 into 21d9b90bdc081b5659ce60f1b6bcd8c100d9e69f - view on LGTM.com

new alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 5 alerts when merging 3c46ef35c84e4d719970c9af9634de4eb08efe45 into 21d9b90bdc081b5659ce60f1b6bcd8c100d9e69f - view on LGTM.com

new alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 7 alerts when merging 4e2e3f8cf1350333808311d660b75245c64cd85d into 21d9b90bdc081b5659ce60f1b6bcd8c100d9e69f - view on LGTM.com

new alerts:

CLAassistant commented 3 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

:white_check_mark: mediumTaj
:white_check_mark: darkmatter2222
:white_check_mark: kevinkowa
:x: semantic-release-bot
You have signed the CLA already but the status is still pending? Let us recheck it.

lgtm-com[bot] commented 3 years ago

This pull request introduces 9 alerts when merging 430aa9bb36fbd7a58a53d4e822b4cc66f07bbcc7 into 21d9b90bdc081b5659ce60f1b6bcd8c100d9e69f - view on LGTM.com

new alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 9 alerts when merging 3ad53a873a2b1f3d7f950ecb9f8a49c2b1e30fac into 427b4c86769337a0ba0bc521860df1280728270d - view on LGTM.com

new alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 9 alerts when merging 133b5a1191671df64ceab77bf4dff8dd7477319a into 427b4c86769337a0ba0bc521860df1280728270d - view on LGTM.com

new alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 10 alerts when merging 736ce1dc42184f7f83e02b271f884d22fe72ccde into 427b4c86769337a0ba0bc521860df1280728270d - view on LGTM.com

new alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 12 alerts when merging e1c323d42dbf78ed99bd3870088f4f4b1cd3dc03 into 427b4c86769337a0ba0bc521860df1280728270d - view on LGTM.com

new alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 14 alerts when merging 23a4cee57e59cf9e968ee0ea0b5ef04d174b4936 into 427b4c86769337a0ba0bc521860df1280728270d - view on LGTM.com

new alerts:

mediumTaj commented 3 years ago

Also CI is failing - can you take a look

lgtm-com[bot] commented 3 years ago

This pull request introduces 14 alerts when merging 24fe885e7b03efcd4e7c6f8d842d0a17dc1a9bea into 427b4c86769337a0ba0bc521860df1280728270d - view on LGTM.com

new alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 14 alerts when merging 1809b0d0ceecdb022f9f2dc15536f562dbe734e5 into 427b4c86769337a0ba0bc521860df1280728270d - view on LGTM.com

new alerts:

mediumTaj commented 3 years ago

@kevinkowa have all changes been addressed?

kevinkowa commented 3 years ago

@kevinkowa have all changes been addressed?

@mediumTaj I just committed a few things that addressed the last requests and cleaned up the code.

lgtm-com[bot] commented 3 years ago

This pull request introduces 13 alerts when merging 962e062ef4b4cbdb331337d7f2c455a038034b4e into 427b4c86769337a0ba0bc521860df1280728270d - view on LGTM.com

new alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 13 alerts when merging 69dec7440c5999560c2f2999996f14b261feffbe into 427b4c86769337a0ba0bc521860df1280728270d - view on LGTM.com

new alerts: