Closed ancogamer closed 3 years ago
This issue has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@repjarms can you take a look when you can
@ancogamer we appreciate the contribution. I can't seem to find anywhere in the core
, v4
or the current version, where NewBaseService
expects the arguments that you list in your PR.
In v4
, it accepts a single argument of the options model. https://github.com/IBM/go-sdk-core/blob/2f88b9f5962c7acb20ef6335522a5a0c3fec90ce/v4/core/base_service.go#L84
In 3.3.1
, it also accepts the single options model. https://github.com/IBM/go-sdk-core/blob/v3.3.1/core/base_service.go#L69
In 2.1.1.
, which is the current version specified in the go.mod
, it also defines a single options model. https://github.com/IBM/go-sdk-core/blob/v3.3.1/core/base_service.go#L69
Can you provide more information about the version of go-sdk-core
that you are using that expects this set of arguments for the NewBaseService
?
Honest, i dont remeber, i fixed by copying the libs like go-sdk-core and changing. you can check the files on this repo( https://github.com/ancogamer/awesomeProject/blob/dfa26ede39a373d7d001e6268808b32f5fade270/core/base_service.go#L67 ). I will look more deep, see if i can find or remember what was the go mods imports.
Summary
Well the https://github.com/IBM/go-sdk-core/tree/master/v4/core is at v4 there, this func just use 1 param (options *ServiceOptions), i didn't changed anything else, to avoid problems with compatibily and security. If is possible, i think will be better do a review of this sdk and the speech to text doc ( https://cloud.ibm.com/apidocs/speech-to-text ).
Best of all, thanks for your time for your friend in Brazil, João Vitor (@ancogamer).