watson-developer-cloud / node-red-node-watson

A collection of nodes for the IBM Watson services
Apache License 2.0
82 stars 86 forks source link

Update links to natural-language-classifier #242

Closed SirSpidey closed 7 years ago

SirSpidey commented 7 years ago

Links have changed. Smarterplanet is deprecated, and filenames have changed with move to Markdown.

CLAassistant commented 7 years ago

CLA assistant check
All committers have signed the CLA.

chughts commented 7 years ago

The oringianl links were to the documentation for the service, and the tooling. The replaced ones are to the API. Users of the Node-RED nodes are issolat d from the API, but need to understand what they can do with it. Currently th old links redirect.

I will accept the change once I have had a chance to sit down and determine what the new links should be, and can make an immediate change to point at the new documentation pages.

SirSpidey commented 7 years ago

Hi, my diff shows that the top 3 doc links go to the same places, (svc landing page, demo, and api reference).

The toolkit page is now a single page instead of 3, so the new link is to the toolkit page where that "example" content exists. You could link directly to the anchor, but that might change more frequently than the page itself.

If you want me to amend the PR with just the doc links and then send the other changes, I can do that.

chughts commented 7 years ago

The change log is showing two updates

From https://www.ibm.com/smarterplanet/us/en/ibmwatson/developercloud/doc/nl-classifier/data_format.shtml to http://www.ibm.com/watson/developercloud/doc/natural-language-classifier/using-your-data.html

and from https://www.ibm.com/smarterplanet/us/en/ibmwatson/developercloud/natural-language-classifier to http://www.ibm.com/watson/developercloud/natural-language-classifier/api/v1/

both of which are good.