search

watson-developer-cloud / node-red-node-watson

A collection of nodes for the IBM Watson services
Apache License 2.0
82 stars 86 forks source link

Add support of proxy to Conversation Nodes #319

Closed kenime closed 6 years ago

kenime commented 7 years ago

Added support of proxy to Conversation Nodes. Proxy with basic auth is also supported.

CLAassistant commented 7 years ago

CLA assistant check
All committers have signed the CLA.

chughts commented 7 years ago

Please provide an explanation for this pull request.

kenime commented 7 years ago

The title is self explanatory; added proxy support for conversation node.

chughts commented 7 years ago

Unfortunately for you it isn't self explanatory to me.

kenime commented 7 years ago

The underlying request module support http proxy but there is no way to configure in the node property page. The only way to do so was to set node.js global variable http_proxy but it will impact other connections as well, which in many case is not ideal (imagine connection to Watson / internet requires proxy but internal doesn’t). Therefore, I have added proxy configuration to conversation node configuration html and add the corresponding configuration to ServiceSettings.

chughts commented 7 years ago

Has the change been tested, both with and without a proxy?

chughts commented 7 years ago

I can ignore the codacy reports, but I need confirmation that you have successfully tested this code change both behind firewall proxy, and without a proxy.

chughts commented 6 years ago

I would like to include this fix, so please reconsider resubmitting. I will, however, still need you to confirm that the change has been tested to work both with and without a proxy.