watson-developer-cloud / node-red-node-watson

A collection of nodes for the IBM Watson services
Apache License 2.0
82 stars 86 forks source link

Bump node module "request" version and fixed IE syntax error #356

Closed kenime closed 6 years ago

kenime commented 6 years ago

1) Prior to version 2.74.0 the request npm module was using tough-cookie < 2.3.0 which has a high ReDOS vulnerability rating. They have updated to use the newest version of tough-cookie that does not have the vulnerability in >= 2.74.0 version of request, hence I bumped request to version ~2.83.0. No breaking change was observed.

2) NLU v1.html is using ECMA5.1 syntax which breaks in IE11, so I updated the code to revert to ECMA3 syntax (minimal impact only).