watson-developer-cloud / node-red-node-watson

A collection of nodes for the IBM Watson services
Apache License 2.0
82 stars 86 forks source link

Timeout for Conversation Node (and other nodes) #382

Closed kenime closed 6 years ago

kenime commented 6 years ago

I am considering adding a timeout parameter for conversation node such that if Watson cannot response after the configured period, the node will prompt error.

There are 2 ways to do so, either I use a process.env variable (such that it will be applicable to all watson nodes), or I only add it to the conversation node's v1.html (if other watson node wants to have such parameter they will have to add so to the html)

Any comment or suggestion which way I should opt for?

chughts commented 6 years ago

My preference would be to add it to the node configuration, defaulting to no timeout.

jimbarnebee commented 6 years ago

Suggestion - Take a look at the code related to node-red-contrib-watson-ucg-custom:0.5.6 - i think it might have something useful as it is a extension of the Watson node with the timeout of the npm exposed.           ----- Original message -----From: Soheel Chughtai notifications@github.comTo: watson-developer-cloud/node-red-node-watson node-red-node-watson@noreply.github.comCc: Subscribed subscribed@noreply.github.comSubject: Re: [watson-developer-cloud/node-red-node-watson] Timeout for Conversation Node (and other nodes) (#382)Date: Wed, Feb 28, 2018 5:50 AM  My preference would be to add it to the node configuration, defaulting to no timeout. —You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or mute the thread.

 

chughts commented 6 years ago

Implemented, waiting packaging into release

chughts commented 6 years ago

implemented only in Conversation node - released in 0.6.7