search

watson-developer-cloud / node-red-node-watson

A collection of nodes for the IBM Watson services
Apache License 2.0
82 stars 86 forks source link

added url for different gateway url #391

Closed psyntium closed 6 years ago

CLAassistant commented 6 years ago

CLA assistant check
All committers have signed the CLA.

chughts commented 6 years ago

I am going to reject this pull request for a number of reasons:

  1. It is only possible to create an instance of Visual Recognition in the US South and UK Regions, where the default endpoint is used.
  2. Any implementation needs to be consistent with how endpoint setting has been implemented in other nodes, eg. Conversation, Discovery, STT etc.
  3. Dedicated Cloud instances of Visual Recognition use a userid / password rather than an API key, so an implementation would need to be flexible. The reason this hasn't been implemented yet, is that I am not able to instantiate an instance of node-red in a dedicated instance, so can not test this out.