search

watson-developer-cloud / node-red-node-watson

A collection of nodes for the IBM Watson services
Apache License 2.0
82 stars 86 forks source link

Add ability to authenticate with an API key to newer NLU instances. #414

Closed seanmtracey closed 6 years ago

seanmtracey commented 6 years ago

New NLU services created in regions using resource groups (Sydney) don't use a username/password combination to authenticate a client, they use API keys.

This PR adds an additional API key field to the UI, and passes that along to the NLU service (whilst maintaining to ability to still authenticate with older NLU instances with username / passwords )

CLAassistant commented 6 years ago

CLA assistant check
All committers have signed the CLA.

chughts commented 6 years ago

I have a pull request with similar changes to - Assistant, Discovery, Speech to Text, Text to Speech and Tone Analyzer. Wasn't aware that NLU had also been updated.

My pull request has been abeyant as Speech to Text recognition fails with the IAM Keys, and there is an open issue on the SDK.

I will accept this pull request, as there are no conflicts. I may roll in some of the other changes, with a broken speech recognition.

seanmtracey commented 6 years ago

Cool. It appears that resource groups for NLU are being rolled out one region at a time, which puts us in an awkward position. I figured this was a reasonable middle ground to handle both scenarios :)