Added ability to disable ssl verification for Assistant node.

watson-developer-cloud / node-red-node-watson

A collection of nodes for the IBM Watson services

Apache License 2.0

82 stars 86 forks source link

Added ability to disable ssl verification for Assistant node. #431

Closed kenime closed 5 years ago

kenime commented 5 years ago

Deliberately didn't add this option to dashboard as to avoid accidental security issue.

Also, by supporting msg.params only, it means technical people (e.g. developer) is involved whom should know the consequence of this option.

chughts commented 5 years ago

Before I accept this, can you confirm that setting disable_ssl_verification = true actually has an effect. I couldn't find anything going up the stack - watson-developer-cloud, request that mentions disable_ssl_verification as the setting to use.

chughts commented 5 years ago

Found it in the documentation - https://www.npmjs.com/package/watson-developer-cloud - but not in the code!

kenime commented 5 years ago

Sorry I missed your message - yes, it is in the documentation and I cross-checked with the code in watson-developer-cloud as well (lib/base_service.ts)