search

watson-developer-cloud / node-sdk

:comet: Node.js library to access IBM Watson services.
https://www.npmjs.com/package/ibm-watson
Apache License 2.0
1.48k stars 668 forks source link

[speech-to-text] please support customization_id #320

Closed zywind closed 7 years ago

zywind commented 7 years ago

For some reason, this is supported by speech-javascript-sdk (as can be seen here: https://github.com/watson-developer-cloud/speech-javascript-sdk/blob/master/speech-to-text/recognize-stream.js#L31) but not by node-sdk.

nfriedly commented 7 years ago

Hey, sorry for the delay in responding. You're right, this should be supported. Do you think you can send me a Pull Request with the change + a unit test to go with it?

nfriedly commented 7 years ago

Op, I didn't realize quite how big this update was yesterday, I was just thinking of adding a new customization_id parameter to the existing methods. If you want to do that (or the entire task of adding support for managing custom models/copra/words), let me know; but if not, I'll try and get it all finished in the next couple of weeks.

zywind commented 7 years ago

Please go ahead. I won't be working on this. Thanks!

nfriedly commented 7 years ago

Fixed in #329, should be released in v2.7.0 once the CI loop finishes.