search

watson-developer-cloud / node-sdk

:comet: Node.js library to access IBM Watson services.
https://www.npmjs.com/package/ibm-watson
Apache License 2.0
1.48k stars 670 forks source link

Discovery Node SDK - Query method wrong parameter definition #469

Closed lgbaeza closed 7 years ago

lgbaeza commented 7 years ago

https://www.ibm.com/watson/developercloud/discovery/api/v1/?node#query-collection

At the page above, the method for query has a wrong definition of the parameters, instead of: discovery.query(('{environment_id}', '{collection_id}', '{query_string}'), ...)

should be discovery.query({'{environment_id}', '{collection_id}', '{query_string}'}, ...)

because according to SDK doc found at https://github.com/watson-developer-cloud/node-sdk/blob/master/discovery/v1.js line 457, the method receives a parameter object "{}"

nfriedly commented 7 years ago

Yep, good catch.

@SirSpidey Can you handle / delegate this one?

SirSpidey commented 7 years ago

@lgbaeza @nfriedly: Got it. Have created an issue against our internal repo

SirSpidey commented 7 years ago

Closing this because it's not an SDK issue. Luis, ping me if you want the internal issue