Fix on_close propogation + bump websocket-client

watson-developer-cloud / python-sdk

:snake: Client library to use the IBM Watson services in Python and available in pip as watson-developer-cloud

https://pypi.org/project/ibm-watson/

Apache License 2.0

1.45k stars 828 forks source link

Fix on_close propogation + bump websocket-client #817

Open wwwehr opened 2 years ago

wwwehr commented 2 years ago

Satisfies https://github.com/watson-developer-cloud/python-sdk/issues/810

Also, the websocket client class sends messages to the on_close handler that do not match the signature that result in an error:

from callback <bound method SynthesizeListener.on_close of
 <ibm_watson.websocket.synthesize_listener.SynthesizeListener object at
 0x123456789>>: on_close() takes 2 positional arguments but 4 were given

This PR fixes this issue.

CLAassistant commented 2 years ago

All committers have signed the CLA.

wwwehr commented 2 years ago

@jeff-arn @kevinkowa @hsaylor

Hoping to get this reviewed and merged. I thought I followed the contributors notes - please advise if I need to do anything else!