search

watson-developer-cloud / ruby-sdk

:diamonds: Ruby SDK to use the IBM Watson services.
Apache License 2.0
44 stars 19 forks source link

v1.0.0 #81

Closed mamoonraja closed 5 years ago

mamoonraja commented 5 years ago

This is the first major release for Ruby SDK 💎, this PR includes:

To Do's

Closes https://github.com/watson-developer-cloud/ruby-sdk/issues/56

mamoonraja commented 5 years ago

@mediumTaj Regenerated and looks like it is up to date, making changes for core version and bumpversion now

codecov-io commented 5 years ago

Codecov Report

Merging #81 into master will decrease coverage by 1.97%. The diff coverage is 99.02%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #81      +/-   ##
=========================================
- Coverage   99.68%   97.7%   -1.98%     
=========================================
  Files          16      18       +2     
  Lines        4380    2705    -1675     
=========================================
- Hits         4366    2643    -1723     
- Misses         14      62      +48
Impacted Files Coverage Δ
lib/ibm_watson/speech_to_text_v1.rb 100% <100%> (ø) :arrow_up:
lib/ibm_watson/discovery_v1.rb 100% <100%> (ø) :arrow_up:
lib/ibm_watson/personality_insights_v3.rb 100% <100%> (ø) :arrow_up:
lib/ibm_watson/natural_language_classifier_v1.rb 100% <100%> (ø) :arrow_up:
lib/ibm_watson/language_translator_v3.rb 99.31% <100%> (-0.3%) :arrow_down:
lib/ibm_watson.rb 100% <100%> (ø) :arrow_up:
lib/ibm_watson/visual_recognition_v3.rb 100% <100%> (+5.05%) :arrow_up:
lib/ibm_watson/assistant_v1.rb 100% <100%> (ø) :arrow_up:
lib/ibm_watson/compare_comply_v1.rb 99.39% <100%> (-0.61%) :arrow_down:
lib/ibm_watson/authenticators.rb 100% <100%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c3d8c94...39ebba7. Read the comment docs.

mediumTaj commented 5 years ago

Mamoon, can you regenerate discovery using API def ef9010ab7de1b1fc7628a340cab118e2f00dd51d? There were some issues with some of the cpd only functionality that was added

mediumTaj commented 5 years ago

We also need MIGRATION-V1.md here

mamoonraja commented 5 years ago

@mediumTaj Working on it, should be in soon.

mamoonraja commented 5 years ago

@SirSpidey wrapping it up, it's in to-do list above :)

mamoonraja commented 5 years ago

@SirSpidey @mediumTaj Migration guide is in.

watson-github-bot commented 5 years ago

:tada: This PR is included in version 1.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: