search

watson-developer-cloud / speech-to-text-swift

Speech-to-Text example using the Swift SDK
Apache License 2.0
34 stars 17 forks source link

With the current SDK the code is not working #14

Closed foward closed 6 years ago

foward commented 6 years ago

I have several errors just using the code as-is, with the current version of Watson-SDK ...could you please check ? Thanks

foward commented 6 years ago

Fixed using and replacing those lines...

screen shot 2018-05-28 at 12 59 40 screen shot 2018-05-28 at 12 59 35 screen shot 2018-05-28 at 12 59 27
germanattanasio commented 6 years ago

It looks like you know what to change @foward. Do you mind creating a PR?

foward commented 6 years ago

sure but I don't have access to do it :) , I have the commit already waiting ... :)

germanattanasio commented 6 years ago

If you forked the repo, you have a copy of this in your namespace which is where you probably did the change. In order to merge that change with this repo, you need to create a PR.

Here are the steps https://help.github.com/articles/creating-a-pull-request/

foward commented 6 years ago

PR done ...just waiting for approval 👍 Thanks

germanattanasio commented 6 years ago

Thanks @foward I've asked @mkistler to look at it https://github.com/watson-developer-cloud/speech-to-text-swift/pull/15