search

watson-developer-cloud / text-to-speech-nodejs

This is a deprecated Watson Text to Speech Service Demo. A link to the newly supported demo is below
https://www.ibm.com/demos/live/tts-demo/self-service/
Apache License 2.0
349 stars 273 forks source link

Fix prosody syntax error #74

Closed wichert closed 7 years ago

wichert commented 7 years ago

Using an explicit + in the prosody rate, for example <prosody rate="+15%"> results in this error:

{
   "code_description": "Bad Request", 
   "code": 400, 
   "error": "Tag <prosody> has invalid attribute rate= 10%"
}
nfriedly commented 7 years ago

I don't think that + is disallowed, I think something in the stack was converting that into a space (which is disallowed).

I think the SDK should probably catch these and urlencode them.

nfriedly commented 7 years ago

Actually, the SDK does do this, but the demo isn't using the SDK...

ehdsouza commented 7 years ago

Fixed in https://github.com/watson-developer-cloud/text-to-speech-nodejs/pull/81

ehdsouza commented 7 years ago

@wichert Thanks for the Pull Request. I fixed the encoding issue and did some other updates in #81