search

watson / airplanejs

📡 ✈️ App that picks up ADS-B radio signals from airplanes and plots them in real time on a map in your browser
MIT License
685 stars 46 forks source link

Modified FlightRadar24 link to open in new tab with external link indicator #5

Open timtheguy opened 6 years ago

timtheguy commented 6 years ago

Purpose

When using the AirplaneJS software, a user may want to single-handedly open the FlightRadar24 information for an aircraft quickly. This pull request enables that functionality by opening the external link to the FlightRadar24 website in a new tab by default. A user can close the tab to return to the AirplaneJS session in another. This addresses issue #4.

Approach

The generated URL to FlightRadar24 will now target a new tab through the addition of target="_blank", and include an indicator that it is an external link. This is good practice for any site navigating users away from the parent domain.

Testing

Tested and working on Chrome 63.0.3239.84, Mac OS X El Capitan:

image

digitalica commented 5 years ago

looks good to me!

timtheguy commented 5 years ago

Hi @watson - what would it take to merge this PR? Cheers!