search

watson / bonjour

A Bonjour/Zeroconf protocol implementation in JavaScript
MIT License
623 stars 143 forks source link

Replace simple dependency and drop 12 sub-deps 🎉 #62

Closed fregante closed 2 years ago

fregante commented 3 years ago

Faster and lighter? Sign me up!

https://www.npmjs.com/package/fast-deep-equal

deep-equal is downloading a lot of dependencies: https://npm.broofa.com/?q=bonjour

mdidon commented 3 years ago

@fregante We have implemented in https://github.com/onlxltd/bonjour-service if this is of any use.

jhurliman commented 3 years ago

@mdidon great to see active development on a successor project? Does it address https://github.com/watson/bonjour/issues/51 by chance?

mdidon commented 3 years ago

@jhurliman Thanks for bringing this to my attention. Not yet, we're working through the issues/PRs listed under the original repo but I'll have a look into it next week.

fregante commented 3 years ago

Friendly ping @watson. 😃 I know this repo is dormant, but the 2 packages are equivalent and would be a pretty easy improvement.

toastal commented 2 years ago

In April 2022, Node.js v12.x was EoL as well. Might as well move the goal post to v14.x for latest maintained LTS. It would be a welcome update to get better performance and a smaller bundle with less dependencies for teams to audit. This project is being used in the massive project Quill and webpack-dev-server which would see a benefit upstream.