search

watson / ci-info

Get details about the current Continuous Integration environment
MIT License
320 stars 49 forks source link

fix: Support isPR for gitlab #59

Closed SassNinja closed 3 years ago

SassNinja commented 3 years ago

Gitlab PR or rather MR (Merge Request) detection didn't work because the pr setting was missing in vendors.json

If fixed this by adding CI_MERGE_REQUEST_ID which identifies a MR in gitlab. https://docs.gitlab.com/ee/ci/variables/predefined_variables.html

Closes #58

sibiraj-s commented 3 years ago

Thanks @SassNinja

SassNinja commented 3 years ago

@sibiraj-s many thanks for the lightning fast merge!

I hope to see this published on npmjs soon (2.0.1) so I can update / make PR in the other (eslint) package which depends on ci-info

sibiraj-s commented 3 years ago

I hope to see this published on npmjs soon (2.0.1) so I can update / make PR in the other (eslint) package which depends on ci-info

I don't have publish permissions. I will try to reach @watson once again.