search

watson / ci-info

Get details about the current Continuous Integration environment
MIT License
321 stars 50 forks source link

Consider another heuristics USER=tester? #8

Closed stefanpenner closed 6 years ago

stefanpenner commented 6 years ago

Some companies, have a more bespoke CI setup, is there any interest in also adding the check:

require('username').sync() === 'tester'
watson commented 6 years ago

Interesting heuristic. I wonder how common the tester user is. If we used that for detecting CI, we wouldn't be able to say much about it though. But I guess we could have catch all name like unknown or something.

Do you know how common using this username is?

stefanpenner commented 6 years ago

I’m not sure how common it is. But I can Only speak to the company I work for using this for its bespoke CI system.

I’m not sure how reliable the above is, I wouldn’t want to push this and introduce a large number of false positives.

watson commented 6 years ago

Do you mind if I leave this issue open for a while longer to see if anybody else have any input? I'm currently leaning towards not supporting something like this though. But let's see if others have any input 😃

stefanpenner commented 6 years ago

@watson sounds good to me.

watson commented 6 years ago

I'll close this issue for now. Feel free to leave a comment if there's anything new 😃