watson / ci-info

Get details about the current Continuous Integration environment
MIT License
319 stars 49 forks source link

chore: create typings at pre-commit hook #97

Closed gkampitakis closed 1 year ago

gkampitakis commented 1 year ago

Hey :wave: thanks a lot for the work here :clap: . I have noticed from time to time issues with keeping typings up to date and I have seen the desire of automating them. This is not automation exactly but what it does runs a check on CI to create the typings. If there is git diff it means they are not up to date and it fails.

of course it will also fail if you probably do it by hand. I can add a "this is generated file" header. Tell me if this would help i can adjust it better.

sibiraj-s commented 1 year ago

Thank you for this. That is a pain definitely.

I can add a "this is generated file" header.

Yes. That would be better.

Also, rather than being in a lint step. It can be also generated and committed using the pre-commit step. We can use husky for this may be. Thoughts? For example see here

gkampitakis commented 1 year ago

Yes, adding pre-commit sounds much better. Will update the pr :smile:

sibiraj-s commented 1 year ago

@gkampitakis . Changes looks good. Please fix the CI.

gkampitakis commented 1 year ago

I ran standard --fix and the tests look good. Thank you :smile:

sibiraj-s commented 1 year ago

Thanks @gkampitakis. Not making any release as this has no user impact.