Closed gkampitakis closed 1 year ago
Yes, adding pre-commit sounds much better. Will update the pr :smile:
@gkampitakis . Changes looks good. Please fix the CI.
I ran standard --fix
and the tests look good. Thank you :smile:
Thanks @gkampitakis. Not making any release as this has no user impact.
Hey :wave: thanks a lot for the work here :clap: . I have noticed from time to time issues with keeping typings up to date and I have seen the desire of automating them. This is not automation exactly but what it does runs a check on CI to create the typings. If there is git diff it means they are not up to date and it fails.
of course it will also fail if you probably do it by hand. I can add a "this is generated file" header. Tell me if this would help i can adjust it better.