search

watson / mongodown

A drop-in replacement for LevelDOWN that runs on MongoDB
MIT License
28 stars 16 forks source link

Update dependencies #5

Closed Kreozot closed 7 years ago

Kreozot commented 8 years ago

Why?

Because early versions of mongojs package has many legacy dependencies which have to be installed with third-party tools like python (e.g. nan package - http://npm.anvaka.com/#/view/2d/mongojs/1.0.0)

With new versions is much more easy to install the package without extra system dependencies.

let me know if you want me to downgrade deps a little bit.

Kreozot commented 8 years ago

Yeah, test failing in node 0.8 because of os.endianness() which was added in v0.9.4. But who uses node 0.8? Is it necessary to test in it? Maybe will be better to add tests for modern version of node?

Kreozot commented 8 years ago

Tests for mongo 2.8 fails because the repo (http://repo.mongodb.org/apt/ubuntu) doesn't have this version.

watson commented 7 years ago

@Kreozot thanks :) I'll just update the CI test matrix so it passes and take a look

Kreozot commented 7 years ago

I'm not allowed to restart the build. Can you please restart it?

watson commented 7 years ago

I fixed the tests in master and rebased the pull request. All tests are now parsing. I've published this as v1.1.0 on npm 😃 Thanks again for the contribution!