search

watsonbox / ios_google_places_autocomplete

Google Places address entry for iOS (Swift)
MIT License
269 stars 69 forks source link

It doesn't seem to be working with Swift 2 new syntax #16

Closed rogerluan closed 9 years ago

rogerluan commented 9 years ago

Tried running the project on Xcode 7 and it asked me to convert the project to Swift 2 new syntax, although it wasn't successful doing so.

briva commented 9 years ago

Same issue.

thekie commented 9 years ago

+1

piercifani commented 9 years ago

You can check out this PR

IbrahimYildirim commented 9 years ago

+1 And @watsonbox its cool you have made this, but why didn't you organize it so it would be easier get an idea of whats going on and maybe made it more generic? Putting all code in one file is not good practise, seriously its like a labyrinth. @piercifani downloaded your changes, but gives me the error: diff: /../Podfile.lock: No such file or directory diff: /Manifest.lock: No such file or directory error: The sandbox is not in sync with the Podfile.lock. Run 'pod install' or update your CocoaPods installation.

Tried everything to make it build, but just gave up.

watsonbox commented 9 years ago

I'll try to find some time at some point to have a look at this myself. I haven't been able to upgrade due to working on an older project.

@IbrahimYildirim I put all the code in one file so it could be easily imported into projects targeting iOS 7. See the installation instructions for more detail. This is the same approach taken by SwiftyJSON and also AlamoFire back when it supported iOS 7, to name but two.

watsonbox commented 9 years ago

Merged #25