Swift 2.0 - Githubissues

watsonbox / ios_google_places_autocomplete

Google Places address entry for iOS (Swift)

MIT License

269 stars 72 forks source link

Swift 2.0 #25

Closed samscam closed 8 years ago

samscam commented 8 years ago

Swift 2.0 - should all compile and test ok.

Cocoapods re-integrated using v0.39.0 and use_frameworks!
.travis.yml changed to use xcode7 image
OHHTTPStubs updated to v4.3
Test targets and build settings generally fiddled with and fixed.
GooglePlacesRequestHelpers has some stray bits of error passing from my fork which I've left in.

watsonbox commented 8 years ago

Awesome, thanks for all this I'll go through it properly ASAP.

watsonbox commented 8 years ago

I see this warning when I open the project - is there anything we can do about that?

screen shot 2015-10-13 at 13 39 55

watsonbox commented 8 years ago

Merged this and found a way to add back the integration test. I haven't fully looked into it but I expect the updated version of FBSnapshotTestCase resolves the issues you were having. Let me know if this now works locally for you. See also the .travis.yml file for running on the command line.

I haven't had time to fully look through this PR but will review it properly before releasing a new version. The main thing is that we get a working XCode 7 / Swift 2 project out there, so thanks a lot for that.

samscam commented 8 years ago

Woo! Good stuff :+1:

Was just looking into the the validate project settings thing. It does that for me in XCode 7.1 beta but not production 7.0.1. Otherwise I'd have ticked the box already ;-)