search

watsonbox / ios_google_places_autocomplete

Google Places address entry for iOS (Swift)
MIT License
269 stars 72 forks source link

changed type to types to query a place by type #4

Closed nafetswirth closed 9 years ago

nafetswirth commented 9 years ago

I got wrong results when searching for cites, so i checked to docs and it seems the correct param name is types. For reference

watsonbox commented 9 years ago

Thanks for this. Can you update the tests, too? It's probably just a case of updating the stub URL.

nafetswirth commented 9 years ago

First of all sorry for not testing in the first place. this was my first pull request :p I sure can change that stub but it shouldn't be the reason for the failing build. I noticed that when testing in the iPhone 6 simulator the tests will fail no matter if the query parameter is type or types. Tests succeed in iphone 5s. It may be the screensize as it seems the snapshot image sizes differ.

nafetswirth commented 9 years ago

4s tests are also failing

watsonbox commented 9 years ago

Yes you need to run the tests in the 5/5S simulator which matches the screenshot sizes.