Replace action responses with intents

watsonwork / watsonwork-weather

A sample cognitive app that listens to messages posted to a space in IBM Watson Workspace and understands the natural language conversation happening in the space

Apache License 2.0

6 stars 15 forks source link

Replace action responses with intents #3

Open CyrusJia opened 7 years ago

jsdelfino commented 7 years ago

Thanks for your contribution. What you're suggesting here makes sense to me. I reviewed your changes and made some comments (the main comment is that your IDE seems to have introduced many formatting changes that make the diff difficult to review...) I will happy to review a revised version of the pull request. Thank you!

CyrusJia commented 7 years ago

I have updated the pull request after revisions as per your comments. Please take a look. Thanks.

CyrusJia commented 7 years ago

I've updated the pull request based on those two suggestions. Please let me know if everything is finalized for the merge. Thanks!

jsdelfino commented 7 years ago

Merged your changes from pull request #4 in commit 454b22c.

Leaving the issue open for now as I think we're missing changes to watson.json (removing the Watson Conversation dialog nodes as they're not necessary anymore.)