search

wavded / ogr2ogr

An ogr2ogr wrapper library
MIT License
216 stars 46 forks source link

Adds version() function #108

Closed molynerd closed 3 months ago

molynerd commented 3 months ago

resolves #107

what I like

It's fairly concise and easy to use.

what I don't like

It doesn't honor the command arg on the default function and I don't think it should either. The point of version() is to understand what the lib is going to do by default. Ideally, it's something that you log or store for triage purposes. If an implementer is calling ogr2ogr from a novel location, I suspect that knowing the version number isn't something they're interested in. Additionally, honoring the command arg would require significant rework of the default function, as the input arg would not make sense in the context of getting the version of the command line utility. Alternatively, one could argue that the version function could simply take in a command arg and solve this problem, but I'm not sure if that's desired. Happy to take feedback here.

wavded commented 3 months ago

@molynerd Thanks so much. Sorry I was busy and then on vacation so did not get to this till now. I think this will work for now, is simple and unobtrusive.