wave-harmonic / crest

A class-leading water system implemented in Unity
MIT License
3.48k stars 480 forks source link

Waves not forming properly, LOD and other strangeness #279

Closed Draydak closed 5 years ago

Draydak commented 5 years ago

Describe the bug Fresh download of Crest (29th June 2019) from Git. Open in Unity, open any demo scene and the waves are all Muted / flat. The Whirlpool scene was craziest, see video. There does not appear to be any wake / bow wake on any boats. But it could just be so shallow, it's not visible.

LOD appears to be behaving oddly, also only appearing in bottom image slot (again see video)

Screenshots / video Crest Issue

image

Log No error's / problems in Log at all.

Versions Git version, master branch downloaded (29th June). Unity 2018.4.2f1

To Reproduce Download from Git master branch to empty folder. Open in Unity, open any demo scene. No changes, no modifications, not added to existing project etc.

Platform Editor and standalone Windows 10 Nvidia Geforce GT 650M

Additional context I believe the graphics card is fully DX11 compatible, so should be capable of handling required shaders. (it worked with earlier versions). All drivers are up-to-date.

daleeidd commented 4 years ago

I might be experiencing this issue. Confirmed working normal (7.0) before texture arrays. My situation is a little different though:

MacOS Catalina (Metal) Intel(R) Core(TM) i5-8500B CPU @ 3.00GHz I have an RX580 as an eGPU Unity 2018.4 and 2019.2 (built-in pipeline) Crest version 8.0 and master

When not using the eGPU (Intel iGPU), it only occurs when LOD resolution is set to 384 (default). But if I reduce it to 256 it works correctly. If I use the eGPU, this issue doesn't occur whether set to 256 or 384.

Metal isn't my target platform, so I don't need it fixed, but I thought it might be useful information. I can provide more information here or in a new issue if desired.

huwb commented 4 years ago

Thanks. This seems like a different cause / problem. Just to confirm, theres no errors or warnings in the log? If you're up for making a new issue i think that would be useful. Thanks

daleeidd commented 4 years ago

No errors or warnings. Can do! I'll test it on another Mac first. I suspect I might have faulty hardware. Probably not the issue here but I might as well.

moosichu commented 4 years ago

I've created a seperate issue for the weirdness on Macs as they are unrelated to this (I think). #384

Thanks for spotting this @daleeidd! I'm jumping back onto Crest development after a bit of a hiatus and one of the first things I noticed was that things didn't seem to work on Mac anymore.

moosichu commented 4 years ago

We also tried chasing up the root cause of this with Unity, but they couldn't reproduce the bug and told us to try and see if we could get anyone to check it out on the forums. So might have to do that at some point.