search

wave-harmonic / crest

A class-leading water system implemented in Unity
MIT License
3.48k stars 480 forks source link

[HDRP] Shader Errors on Unity 2020.2 Beta & HDRP 10.1.0+ Versions #698

Closed TeorikDeli closed 3 years ago

TeorikDeli commented 3 years ago

Describe the bug On the beta version of Unity 2020.2 with HDRP 10.1 (and 10.2), Crest shaders gives shader error and doesn't work. It is most probably because of the HDRP 10.1 changes (for example: Removed BLEND shader keywords.). I was using Crest without any problem on Unity 2020.2.0b9 and HDRP 10.0.0.preview27 before. This is not an urgent problem of course, because these versions are still in beta =)

Logs

Shader error in 'Crest/Ocean': undeclared identifier '_BlendMode' at HDRP_Test/Library/PackageCache/com.unity.render-pipelines.high-definition@10.2.0/Runtime/Material/Material.hlsl(51) (on d3d11)

Compiling Vertex program
Platform defines: UNITY_ENABLE_REFLECTION_BUFFERS UNITY_USE_DITHER_MASK_FOR_ALPHABLENDED_SHADOWS UNITY_PBS_USE_BRDF1 UNITY_SPECCUBE_BOX_PROJECTION UNITY_SPECCUBE_BLENDING UNITY_ENABLE_DETAIL_NORMALMAP SHADER_API_DESKTOP UNITY_LIGHT_PROBE_PROXY_VOLUME UNITY_LIGHTMAP_FULL_HDR
Disabled keywords: LOD_FADE_CROSSFADE INSTANCING_ON CREST_FOAM_ON CREST_CAUSTICS_ON CREST_FLOW_ON UNITY_NO_DXT5nm UNITY_ENABLE_NATIVE_SHADOW_LOOKUPS UNITY_METAL_SHADOWS_USE_POINT_FILTERING UNITY_NO_SCREENSPACE_SHADOWS UNITY_PBS_USE_BRDF2 UNITY_PBS_USE_BRDF3 UNITY_NO_FULL_STANDARD_SHADER UNITY_HARDWARE_TIER1 UNITY_HARDWARE_TIER2 UNITY_HARDWARE_TIER3 UNITY_COLORSPACE_GAMMA UNITY_HALF_PRECISION_FRAGMENT_SHADER_REGISTERS UNITY_LIGHTMAP_DLDR_ENCODING UNITY_LIGHTMAP_RGBM_ENCODING UNITY_VIRTUAL_TEXTURING UNITY_PRETRANSFORM_TO_DISPLAY_ORIENTATION UNITY_ASTC_NORMALMAP_ENCODING SHADER_API_GLES30

Actually, there are more shader errors (One of them is in the some Shadow shader I think), but I can't reproduce the log right now.

Versions HDRP 10.1.0+ and Unity 2020.2.0b12 (No problem in HDRP 10.0.0.preview27 and Unity 2020.2.0b9)

emaber commented 3 years ago

Came here to report the same problem! Thank you for reporting it. We had this problem since b10 and it's preventing us to upgrade as we are dependent on features in 2020.2 Beta.

daleeidd commented 3 years ago

Will be fixed for next release (4.7).

daleeidd commented 3 years ago

Crest 4.7 is out so I will close this. Thank you for reporting.

NeistH2o commented 3 years ago

I had to delete the package from the asset store cache in order to get it to import the 4.7 instead of the 4.6, I don't know if it was a bug with unity's package manager but I spent 3 hours trying to figure out why I still had the same error, so just in case it happens to someone, the asset store cache is at C:/Users/[...your user folder...]/AppData/Roaming/Unity/Asset Store-5.x

brucekirkpatrick commented 3 years ago

posted in wrong place, deleted comment.