search

wave-k8s / wave

Kubernetes configuration tracking controller
Apache License 2.0
646 stars 82 forks source link

redundant, possibly misleading content in sample role definition #110

Closed kushal-kumaran closed 1 month ago

kushal-kumaran commented 2 years ago

https://github.com/wave-k8s/wave/blob/c3bdcfe923debc572bec313c84e457d2e592af16/config/rbac/manager_role.yaml lists configmaps and secrets multiple times. The configmaps entries have identical verbs, but the secrets entries has a different set of verbs for one of the occurrences.

https://github.com/wave-k8s/wave/blob/c3bdcfe923debc572bec313c84e457d2e592af16/config/rbac/manager_role.yaml#L27-L36

and

https://github.com/wave-k8s/wave/blob/c3bdcfe923debc572bec313c84e457d2e592af16/config/rbac/manager_role.yaml#L134-L145

Which of these is the appropriate set of verbs? Does wave need update, patch, or delete access to the secrets?

github-actions[bot] commented 2 years ago

This issue has been inactive for 60 days. If the issue is still relevant please comment to re-activate the issue. If no action is taken within 7 days, the issue will be marked closed.