wave-k8s / wave

Kubernetes configuration tracking controller
Apache License 2.0
646 stars 82 forks source link

Moving rbac resources to Kubernetes 1.22+ #120

Closed aravol closed 1 year ago

aravol commented 2 years ago

Fixes #119

mschneider82 commented 2 years ago

thanks, verified it works

@JoelSpeed can you please merge an release a new version?

JoelSpeed commented 2 years ago

I'm no longer involved in this project, CC @icelynjennings

aravol commented 2 years ago

@gargath ?

aravol commented 2 years ago

Still seeing this as an issue on our side

aravol commented 2 years ago

Tests are still having a problem loading up dependencies for checks on this PR - looks like an environment issue?

mwmahlberg commented 2 years ago

@aravol My 2 cents: This should be a conditional and not hard coded. Something in the line of

{{ if .Capabilities.KubeVersion.Minor >= 22 }}
apiVersion: rbac.authorization.k8s.io/v1
{{ else }}
apiVersion: rbac.authorization.k8s.io/v1beta1
{{ end }}

This way, the helm chart will work on "older" versions. Keep in mind that many enterprise kubernetes distributions are usually several versions behind.

aravol commented 2 years ago

That was a choice not to use a conditional statement; the rbac api enetered general availability with Kubernetes 1.8.1, which has been available for nearly five years now and which has already been deprecated by most hosts

mwmahlberg commented 2 years ago

@aravol Well, checks fail anyway -- guess it would be worth digging into that. So much to do, so little time. ;)

nifr commented 2 years ago

Related #125

aaron-trout commented 2 years ago

Bump @icelynjennings can you take a look at this? I can step in to help maintain this project if needs be; let me know!

tw commented 1 year ago

@icelynjennings sorry to tag you again, just wondered if this will be being merged before I make an adjustment locally.

aravol commented 1 year ago

Ended up making the changes locally to get this working

mschneider82 commented 1 year ago

Consider migrate to https://github.com/stakater/Reloader

Wave is not maintained anymore

toelke commented 4 months ago

Thank you for the contribution. I will merge #112 instead of this, as it is the earlier contribution.